enchant3dmango commented on code in PR #47406:
URL: https://github.com/apache/airflow/pull/47406#discussion_r1982039077
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/pod_generator.py:
##########
@@ -504,7 +504,7 @@
pod = yaml.safe_load(stream)
else:
pod = None
- log.warning("Model file %s does not exist", path)
+ log.warning("Model file %s does not exist or is not defined. Using
default model file.", path)
Review Comment:
TLDR: There is no sensitive data in this PR. I think it is a false positive
failure check.
I think this is flagged as sensitive data because of the code at
[kube_config#L32](https://github.com/apache/airflow/blob/main/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py#L32)
that set the field `display_sensitive` to **True**.
The `deserialize_model_file` function (the function I modified in the
attached PR) is indirectly used to
[kube_config#L32](https://github.com/apache/airflow/blob/main/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py#L32)
via the `render_k8s_pod_yaml` function, in
[template_rendering.py#L59](https://github.com/apache/airflow/blob/main/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/template_rendering.py#L59).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
