ashb commented on code in PR #47401:
URL: https://github.com/apache/airflow/pull/47401#discussion_r1983568654
##########
task_sdk/src/airflow/sdk/definitions/connection.py:
##########
@@ -56,7 +58,28 @@ class Connection:
def get_uri(self): ...
- def get_hook(self): ...
+ def get_hook(self, *, hook_params=None):
+ """Return hook based on conn_type."""
+ from airflow.providers_manager import ProvidersManager
+ from airflow.utils.module_loading import import_string
Review Comment:
Because this is in the Task SDK, and long term we don't want to have mixed
imports, but short term delay the import of code outside of Task SDK to the
specific place it is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
