PNL0 commented on code in PR #47557:
URL: https://github.com/apache/airflow/pull/47557#discussion_r1989016938
##########
airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -235,6 +236,23 @@ def patch_dag(
data = patch_body.model_dump(include=fields_to_update, by_alias=True)
+ is_paused = data.get("is_paused")
+ if is_paused is not None:
+ active_dag_runs = session.scalars(
+ select(DagRun).filter(
+ DagRun.dag_id == dag_id,
DagRun.state.in_([DagRunState.RUNNING, DagRunState.QUEUED])
+ )
+ ).all()
+
+ for dag_run in active_dag_runs:
+ if is_paused:
Review Comment:
> I think there is a problem here. It cannot get into else here since the
parent `if` is already ensuring it isn't `None`.
My idea, with the if-else clause, is to cover the cases when the user pauses
the dag (is_paused = true) and unpauses the dag (is_paused = false, so the else
clause).
Maybe this became confusing because of the parent if-clause (to check the
None), but has I said in the other comment, I think that I can safely remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
