ephraimbuddy commented on code in PR #47376:
URL: https://github.com/apache/airflow/pull/47376#discussion_r1983777442
##########
tests/models/test_taskinstance.py:
##########
@@ -4969,16 +4968,14 @@ def test_taskinstance_with_note(create_task_instance,
session):
session.add(ti)
session.commit()
- filter_kwargs = dict(dag_id=ti.dag_id, task_id=ti.task_id,
run_id=ti.run_id, map_index=ti.map_index)
-
- ti_note: TaskInstanceNote =
session.query(TaskInstanceNote).filter_by(**filter_kwargs).one()
+ ti_note: TaskInstanceNote =
session.query(TaskInstanceNote).filter_by(id=ti.id).one()
Review Comment:
```suggestion
ti_note: TaskInstanceNote =
session.query(TaskInstanceNote).filter_by(ti_id=ti.id).one()
```
##########
tests/models/test_taskinstance.py:
##########
@@ -3993,15 +3993,14 @@ def test_clear_db_references(self, session,
create_task_instance):
for table in tables:
assert session.query(table).count() == 1
- filter_kwargs = dict(dag_id=ti.dag_id, task_id=ti.task_id,
run_id=ti.run_id, map_index=ti.map_index)
- ti_note =
session.query(TaskInstanceNote).filter_by(**filter_kwargs).one()
+ ti_note = session.query(TaskInstanceNote).filter_by(id=ti.id).one()
assert ti_note.content == "sample note"
ti.clear_db_references(session)
for table in tables:
assert session.query(table).count() == 0
- assert
session.query(TaskInstanceNote).filter_by(**filter_kwargs).one_or_none() is None
+ assert
session.query(TaskInstanceNote).filter_by(id=ti.id).one_or_none() is None
Review Comment:
```suggestion
assert
session.query(TaskInstanceNote).filter_by(ti_id=ti.id).one_or_none() is None
```
##########
tests/models/test_taskinstance.py:
##########
@@ -3993,15 +3993,14 @@ def test_clear_db_references(self, session,
create_task_instance):
for table in tables:
assert session.query(table).count() == 1
- filter_kwargs = dict(dag_id=ti.dag_id, task_id=ti.task_id,
run_id=ti.run_id, map_index=ti.map_index)
- ti_note =
session.query(TaskInstanceNote).filter_by(**filter_kwargs).one()
+ ti_note = session.query(TaskInstanceNote).filter_by(id=ti.id).one()
Review Comment:
```suggestion
ti_note =
session.query(TaskInstanceNote).filter_by(ti_id=ti.id).one()
```
##########
tests/models/test_taskinstance.py:
##########
@@ -4969,16 +4968,14 @@ def test_taskinstance_with_note(create_task_instance,
session):
session.add(ti)
session.commit()
- filter_kwargs = dict(dag_id=ti.dag_id, task_id=ti.task_id,
run_id=ti.run_id, map_index=ti.map_index)
-
- ti_note: TaskInstanceNote =
session.query(TaskInstanceNote).filter_by(**filter_kwargs).one()
+ ti_note: TaskInstanceNote =
session.query(TaskInstanceNote).filter_by(id=ti.id).one()
assert ti_note.content == "ti with note"
session.delete(ti)
session.commit()
- assert
session.query(TaskInstance).filter_by(**filter_kwargs).one_or_none() is None
- assert
session.query(TaskInstanceNote).filter_by(**filter_kwargs).one_or_none() is None
+ assert session.query(TaskInstance).filter_by(id=ti.id).one_or_none() is
None
+ assert session.query(TaskInstanceNote).filter_by(id=ti.id).one_or_none()
is None
Review Comment:
```suggestion
assert session.query(TaskInstance).filter_by(ti_id=ti.id).one_or_none()
is None
assert
session.query(TaskInstanceNote).filter_by(ti_id=ti.id).one_or_none() is None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
