Louis Guitton created AIRFLOW-5643:
--------------------------------------
Summary: S3Hook logic is duplicated and could be clearer
Key: AIRFLOW-5643
URL: https://issues.apache.org/jira/browse/AIRFLOW-5643
Project: Apache Airflow
Issue Type: Improvement
Components: aws, hooks
Affects Versions: 1.10.5
Reporter: Louis Guitton
Assignee: Louis Guitton
S3Hook.load_bytes is duplicating the logic of S3Hook.load_file_obj
[https://github.com/apache/airflow/blob/master/airflow/hooks/S3_hook.py#L464-L539|https://github.com/apache/airflow/blob/master/airflow/hooks/S3_hook.py#L465-L539]
Instead, we should stay consistent : S3Hook.load_string is already delegating
the logic to S3Hook.load_bytes, so we can use the same approach to delegate to
S3Hook.load_file_obj
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
