bugraoz93 commented on code in PR #45300:
URL: https://github.com/apache/airflow/pull/45300#discussion_r1990143702
##########
hatch_build.py:
##########
@@ -225,6 +225,8 @@
"itsdangerous>=2.0",
"jinja2>=3.0.0",
"jsonschema>=4.18.0",
+ # Added for CLI
+ "keyring>=25.6.0",
Review Comment:
Yes, the library offers a variety of support, including third-party
backends. I will include them here #47537.
I think we should follow the same recommendation. For example, Keyrings and
Windows Credential Locker are already native libraries. Maybe depends on the
Linux distro, there could be changes but KDE seems legit. Do you have anything
in your mind?
> These recommended keyring backends are supported:
macOS [Keychain](https://en.wikipedia.org/wiki/Keychain_%28software%29)
Freedesktop [Secret
Service](http://standards.freedesktop.org/secret-service/) supports many DE
including GNOME (requires
[secretstorage](https://pypi.python.org/pypi/secretstorage))
KDE4 & KDE5 [KWallet](https://en.wikipedia.org/wiki/KWallet) (requires
[dbus](https://pypi.python.org/pypi/dbus-python))
[Windows Credential
Locker](https://docs.microsoft.com/en-us/windows/uwp/security/credential-locker)
Other keyring implementations are available through [Third-Party
Backends](https://github.com/jaraco/keyring#third-party-backends).
**&TLDR**
I will also include they can still leverage the support for 3rd party
backends stated here
https://github.com/jaraco/keyring?tab=readme-ov-file#third-party-backends
>In addition to the backends provided by the core keyring package for the
most common and secure use cases, there are additional keyring backend
implementations available for other use cases. Simply install them to make them
available:
[keyrings.cryptfile](https://pypi.org/project/keyrings.cryptfile) -
Encrypted text file storage.
[keyrings.alt](https://pypi.org/project/keyrings.alt) - "alternate",
possibly-insecure backends, originally part of the core package, but available
for opt-in.
[gsheet-keyring](https://pypi.org/project/gsheet-keyring) - a backend that
stores secrets in a Google Sheet. For use with
[ipython-secrets](https://pypi.org/project/ipython-secrets).
[bitwarden-keyring](https://pypi.org/project/bitwarden-keyring/) - a backend
that stores secrets in the [BitWarden](https://bitwarden.com/) password manager.
[onepassword-keyring](https://pypi.org/project/onepassword-keyring/) - a
backend that stores secrets in the [1Password](https://1password.com/) password
manager.
[sagecipher](https://pypi.org/project/sagecipher) - an encryption backend
which uses the ssh agent protocol's signature operation to derive the cipher
key.
[keyrings.osx_keychain_keys](https://pypi.org/project/keyrings.osx-keychain-keys)
- OSX keychain key-management, for private, public, and symmetric keys.
[keyring_pass.PasswordStoreBackend](https://github.com/nazarewk/keyring_pass)
Password Store (pass) backend for python's keyring
[keyring_jeepney](https://pypi.org/project/keyring_jeepney) - a pure Python
backend using the secret service DBus API for desktop Linux (requires
keyring<24).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
