jieyao-MilestoneHub commented on code in PR #47478:
URL: https://github.com/apache/airflow/pull/47478#discussion_r1990482225
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/exasol_to_s3.py:
##########
@@ -31,29 +32,165 @@
from airflow.utils.context import Context
+class ExasolExportOperator(BaseOperator):
Review Comment:
I initially thought example_exasol_to_s3 should only test the Exasol
connection, so it should work without S3 credentials. This was the main reason
for my changes.
Regarding the code modifications, I first planned to outline my approach (as
I mentioned focusing on separation of concerns) before discussing further. As a
result, my changes were somewhat disorganized—sorry for any confusion caused.
Now that I’ve clarified the issue, I will make further adjustments:
1. Revert exasol_to_s3.py and test_exasol_to_s3.py to their original state.
2. Add example_exasol_to_s3.py to test the full functionality (Exasol
connection, S3 query, and export to S3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
