ASF GitHub Bot commented on AIRFLOW-5640:

SaturnFromTitan commented on pull request #6315: [AIRFLOW-5640] fix 
get_email_address_list types
URL: https://github.com/apache/airflow/pull/6315
   Make sure you have checked _all_ steps below.
   ### Jira
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
   ### Tests
   - [x] My PR adds the following unit tests:
   ### Commits
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> BaseOperator email parameter is wrongly typed and not documented
> ----------------------------------------------------------------
>                 Key: AIRFLOW-5640
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5640
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.5
>            Reporter: Cedrik Neumann
>            Assignee: Martin Winkel
>            Priority: Major
> The {{email}} field is not documented in BaseOperator and furthermore the 
> type annotation {{str}} is wrong 
> [here|https://github.com/apache/airflow/blob/master/airflow/models/baseoperator.py#L273].
> The method {{get_email_address_list}} clearly accepts lists of strings as 
> well as comma and semicolon delimited lists: 
> [here|https://github.com/apache/airflow/blob/88989200a66291580088188f06a6db503ac823e2/airflow/utils/email.py#L123]

This message was sent by Atlassian Jira

Reply via email to