ashb commented on code in PR #47432:
URL: https://github.com/apache/airflow/pull/47432#discussion_r1991092538
##########
airflow/auth/managers/simple/ui/src/login/Login.tsx:
##########
@@ -40,7 +40,10 @@ export const Login = () => {
const onSuccess = (data: LoginResponse) => {
// Redirect to appropriate page with the token
const next = searchParams.get("next")
- globalThis.location.replace(`${next ?? ""}?token=${data.jwt_token}`);
+
+ localStorage.setItem("token", JSON.stringify(data.jwt_token));
Review Comment:
Why JSONify this? The jwt_token is already a string isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
