kacpermuda opened a new pull request, #47673:
URL: https://github.com/apache/airflow/pull/47673
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
In OpenLineage, we use the `DefaultExtractor` to extract lineage metadata
from Operators that implement OL methods. To determine whether a task succeeded
or failed, we previously relied on `ti.state`
[here](https://github.com/apache/airflow/blob/eebdf4e9fbbe9badd1f93dbaf1c9a0d1d2aa357c/providers/openlineage/src/airflow/providers/openlineage/extractors/base.py#L126).
However, in **Airflow 3**, this approach is no longer viable because we now
receive a `RuntimeTaskInstance`. I don’t believe we can directly extract the
state from it, so I adjusted the logic inside OL's listener. Now, depending on
which listener method is called (`on_task_instance_running`,
`on_task_instance_success`, `on_task_instance_failed`), we manually propagate
the current `TaskInstanceState` to the OL's `ExtractorManager`. This change
allows us to invoke appropriate Extractor method (`extract_on_complete` or
newly added `extract_on_failure`).
I think adding a new method to the extractor base class is the simplest
approach, ensuring we don’t break anything for users with existing custom
extractors. The only action required for users with a custom extractor will be
to implement this new method (`extract_on_failure`), but only when using
**Airflow 3** and implementing the `get_openlineage_facets_on_failure` method
in their operators (otherwise in Airflow 3 we will always call
`extract_on_complete` as usual, but user will not be able to retrieve the state
information from `RuntimeTaskInstance`).
This keeps the transition smooth while maintaining backward compatibility.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
