kaxil commented on code in PR #47731:
URL: https://github.com/apache/airflow/pull/47731#discussion_r1993766548
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -445,17 +448,22 @@ def _register_pipe_readers(self, stdout: socket, stderr:
socket, requests: socke
# alternatives are used automatically) -- this is a way of having
"event-based" code, but without
# needing full async, to read and process output from each socket as
it is received.
- self.selector.register(stdout, selectors.EVENT_READ,
self._create_socket_handler(self.log, "stdout"))
+ target_loggers: tuple[FilteringBoundLogger, ...] = (self.log,)
+ if self.verbose_logs_to_main_logger:
+ target_loggers += (log,)
Review Comment:
Yeah `self.process_log` is probably better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
