bugraoz93 commented on PR #45300:
URL: https://github.com/apache/airflow/pull/45300#issuecomment-2723012148

   > Okay, attempted (again) and... there is no "profile" page. Attempted to 
grab the "token" from the browser inspector: 
![image](https://private-user-images.githubusercontent.com/95105677/422528480-86c881a2-7546-42f6-8ece-20ebd905961e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDE5MDc3ODcsIm5iZiI6MTc0MTkwNzQ4NywicGF0aCI6Ii85NTEwNTY3Ny80MjI1Mjg0ODAtODZjODgxYTItNzU0Ni00MmY2LThlY2UtMjBlYmQ5MDU5NjFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAzMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMzEzVDIzMTEyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQwYmEwNmZkYjc4MTNjNTI2YjdiNDY3NzYyYWE5OTcwM2I3N2Q1N2YwYTQyMTAwNmNiYWIxOWFjMjIwNTRkNGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.rKeBgDiysTv0GYTVLnQyuIY6-rfTMM2pUtm91AZBZ0Q)
   > 
   > ...but this was not working, `airflow login auth` was accepting. But then 
got a 403 when attempting to `airflow connections list`. So
   > 
   > (1) Still even after re-reading the Google spec doc I am not able to find 
the right token. Some description is needed, else almost nobody can use the 
CLI. (Hope it is not an individual short-coming just in front of my keyboard) 
(2) I would encourage that if a user calls `airflow auth login --api-token 
<something>` that the token is also validated. It seems it was "just" stored 
but was not working. Or the `airflow connections list` call is broken. (3) With 
every call I was asked for the keystore password. Is there a way to temporarily 
store this in the session? Would be tideous to enter the passphrase of the 
keystore every time. (Or is this a specific shortcoming of the breeze 
container?)
   
   > Okay, attempted (again) and... there is no "profile" page. Attempted to 
grab the "token" from the browser inspector: 
![image](https://private-user-images.githubusercontent.com/95105677/422528480-86c881a2-7546-42f6-8ece-20ebd905961e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDE5MDc3ODcsIm5iZiI6MTc0MTkwNzQ4NywicGF0aCI6Ii85NTEwNTY3Ny80MjI1Mjg0ODAtODZjODgxYTItNzU0Ni00MmY2LThlY2UtMjBlYmQ5MDU5NjFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAzMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMzEzVDIzMTEyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQwYmEwNmZkYjc4MTNjNTI2YjdiNDY3NzYyYWE5OTcwM2I3N2Q1N2YwYTQyMTAwNmNiYWIxOWFjMjIwNTRkNGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.rKeBgDiysTv0GYTVLnQyuIY6-rfTMM2pUtm91AZBZ0Q)
   > 
   > ...but this was not working, `airflow login auth` was accepting. But then 
got a 403 when attempting to `airflow connections list`. So
   > 
   > (1) Still even after re-reading the Google spec doc I am not able to find 
the right token. Some description is needed, else almost nobody can use the 
CLI. (Hope it is not an individual short-coming just in front of my keyboard) 
(2) I would encourage that if a user calls `airflow auth login --api-token 
<something>` that the token is also validated. It seems it was "just" stored 
but was not working. Or the `airflow connections list` call is broken. (3) With 
every call I was asked for the keystore password. Is there a way to temporarily 
store this in the session? Would be tideous to enter the passphrase of the 
keystore every time. (Or is this a specific shortcoming of the breeze 
container?)
   
   
   Thanks for your feedback! They are valuable for me to shape this into 
better. I don't want to ship anything missing or hard to use.
   
   Please don't get me wrong, my aim is not to rush into something and release 
a broken or non-usable piece of work. My thinking was unblocking the huge block 
of work in AIP-81. That block of work is the parallel migration of remote 
commands (~10) to use the client. My thinking was I could fill these gaps in 
the meantime as follow-ups. 
   
   Considering your concerns,
   1) Let me include this in the PR. 
   2) Let me include work with the automated retrieving token into this PR then 
use `--username --password` which is more intuitive for users. Also the 
documentation part and make this already deliverable piece of work in the PR.
   I did the developer tests with all connection commands and multiple cases 
and they were working fine. I am not sure why they didn't work. Let me 
double-check since there are so many moving things and provide more info later.
   3) I haven't started making tests on each OS and each backend. I believe it 
should be limited to the dev package though. I agree I think that should be 
kept in either session or some solution is needed. If it is the same for all OS 
backends, I think it is worth including this as a feature rather would be 
faster than testing each backend and including integrations test for them.
   
   The aim to make AIP-81 happen is the 17th of March week which is the next 
release week. Even if I added those things into this PR, I don't think 
migration of the remote commands can finish in 3 days with all review 
processes. Even if they are all implemented in 1-2 days, they still need to be 
reviewed and merged. We may need to extend the release of integration of API 
and this PR. So that everything can be ready without any friction. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to