jedcunningham commented on code in PR #47760:
URL: https://github.com/apache/airflow/pull/47760#discussion_r1995716078
##########
airflow/api_fastapi/core_api/routes/v2/__init__.py:
##########
@@ -21,36 +21,36 @@
from airflow.api_fastapi.common.router import AirflowRouter
from airflow.api_fastapi.core_api.openapi.exceptions import
create_openapi_http_exception_doc
-from airflow.api_fastapi.core_api.routes.public.assets import assets_router
-from airflow.api_fastapi.core_api.routes.public.backfills import
backfills_router
-from airflow.api_fastapi.core_api.routes.public.config import config_router
-from airflow.api_fastapi.core_api.routes.public.connections import
connections_router
-from airflow.api_fastapi.core_api.routes.public.dag_parsing import
dag_parsing_router
-from airflow.api_fastapi.core_api.routes.public.dag_report import
dag_report_router
-from airflow.api_fastapi.core_api.routes.public.dag_run import dag_run_router
-from airflow.api_fastapi.core_api.routes.public.dag_sources import
dag_sources_router
-from airflow.api_fastapi.core_api.routes.public.dag_stats import
dag_stats_router
-from airflow.api_fastapi.core_api.routes.public.dag_tags import dag_tags_router
-from airflow.api_fastapi.core_api.routes.public.dag_versions import
dag_versions_router
-from airflow.api_fastapi.core_api.routes.public.dag_warning import
dag_warning_router
-from airflow.api_fastapi.core_api.routes.public.dags import dags_router
-from airflow.api_fastapi.core_api.routes.public.event_logs import
event_logs_router
-from airflow.api_fastapi.core_api.routes.public.extra_links import
extra_links_router
-from airflow.api_fastapi.core_api.routes.public.import_error import
import_error_router
-from airflow.api_fastapi.core_api.routes.public.job import job_router
-from airflow.api_fastapi.core_api.routes.public.log import
task_instances_log_router
-from airflow.api_fastapi.core_api.routes.public.login import login_router
-from airflow.api_fastapi.core_api.routes.public.monitor import monitor_router
-from airflow.api_fastapi.core_api.routes.public.plugins import plugins_router
-from airflow.api_fastapi.core_api.routes.public.pools import pools_router
-from airflow.api_fastapi.core_api.routes.public.providers import
providers_router
-from airflow.api_fastapi.core_api.routes.public.task_instances import
task_instances_router
-from airflow.api_fastapi.core_api.routes.public.tasks import tasks_router
-from airflow.api_fastapi.core_api.routes.public.variables import
variables_router
-from airflow.api_fastapi.core_api.routes.public.version import version_router
-from airflow.api_fastapi.core_api.routes.public.xcom import xcom_router
+from airflow.api_fastapi.core_api.routes.v2.assets import assets_router
+from airflow.api_fastapi.core_api.routes.v2.backfills import backfills_router
+from airflow.api_fastapi.core_api.routes.v2.config import config_router
+from airflow.api_fastapi.core_api.routes.v2.connections import
connections_router
+from airflow.api_fastapi.core_api.routes.v2.dag_parsing import
dag_parsing_router
+from airflow.api_fastapi.core_api.routes.v2.dag_report import dag_report_router
+from airflow.api_fastapi.core_api.routes.v2.dag_run import dag_run_router
+from airflow.api_fastapi.core_api.routes.v2.dag_sources import
dag_sources_router
+from airflow.api_fastapi.core_api.routes.v2.dag_stats import dag_stats_router
+from airflow.api_fastapi.core_api.routes.v2.dag_tags import dag_tags_router
+from airflow.api_fastapi.core_api.routes.v2.dag_versions import
dag_versions_router
+from airflow.api_fastapi.core_api.routes.v2.dag_warning import
dag_warning_router
+from airflow.api_fastapi.core_api.routes.v2.dags import dags_router
+from airflow.api_fastapi.core_api.routes.v2.event_logs import event_logs_router
+from airflow.api_fastapi.core_api.routes.v2.extra_links import
extra_links_router
+from airflow.api_fastapi.core_api.routes.v2.import_error import
import_error_router
+from airflow.api_fastapi.core_api.routes.v2.job import job_router
+from airflow.api_fastapi.core_api.routes.v2.log import
task_instances_log_router
+from airflow.api_fastapi.core_api.routes.v2.login import login_router
+from airflow.api_fastapi.core_api.routes.v2.monitor import monitor_router
+from airflow.api_fastapi.core_api.routes.v2.plugins import plugins_router
+from airflow.api_fastapi.core_api.routes.v2.pools import pools_router
+from airflow.api_fastapi.core_api.routes.v2.providers import providers_router
+from airflow.api_fastapi.core_api.routes.v2.task_instances import
task_instances_router
+from airflow.api_fastapi.core_api.routes.v2.tasks import tasks_router
+from airflow.api_fastapi.core_api.routes.v2.variables import variables_router
+from airflow.api_fastapi.core_api.routes.v2.version import version_router
+from airflow.api_fastapi.core_api.routes.v2.xcom import xcom_router
-public_router = AirflowRouter(prefix="/public")
+public_router = AirflowRouter(prefix="/v2")
Review Comment:
We could do either, but `/api/v1` is probably what we should do imo.
##########
airflow/api_fastapi/core_api/routes/v2/__init__.py:
##########
@@ -21,36 +21,36 @@
from airflow.api_fastapi.common.router import AirflowRouter
from airflow.api_fastapi.core_api.openapi.exceptions import
create_openapi_http_exception_doc
-from airflow.api_fastapi.core_api.routes.public.assets import assets_router
-from airflow.api_fastapi.core_api.routes.public.backfills import
backfills_router
-from airflow.api_fastapi.core_api.routes.public.config import config_router
-from airflow.api_fastapi.core_api.routes.public.connections import
connections_router
-from airflow.api_fastapi.core_api.routes.public.dag_parsing import
dag_parsing_router
-from airflow.api_fastapi.core_api.routes.public.dag_report import
dag_report_router
-from airflow.api_fastapi.core_api.routes.public.dag_run import dag_run_router
-from airflow.api_fastapi.core_api.routes.public.dag_sources import
dag_sources_router
-from airflow.api_fastapi.core_api.routes.public.dag_stats import
dag_stats_router
-from airflow.api_fastapi.core_api.routes.public.dag_tags import dag_tags_router
-from airflow.api_fastapi.core_api.routes.public.dag_versions import
dag_versions_router
-from airflow.api_fastapi.core_api.routes.public.dag_warning import
dag_warning_router
-from airflow.api_fastapi.core_api.routes.public.dags import dags_router
-from airflow.api_fastapi.core_api.routes.public.event_logs import
event_logs_router
-from airflow.api_fastapi.core_api.routes.public.extra_links import
extra_links_router
-from airflow.api_fastapi.core_api.routes.public.import_error import
import_error_router
-from airflow.api_fastapi.core_api.routes.public.job import job_router
-from airflow.api_fastapi.core_api.routes.public.log import
task_instances_log_router
-from airflow.api_fastapi.core_api.routes.public.login import login_router
-from airflow.api_fastapi.core_api.routes.public.monitor import monitor_router
-from airflow.api_fastapi.core_api.routes.public.plugins import plugins_router
-from airflow.api_fastapi.core_api.routes.public.pools import pools_router
-from airflow.api_fastapi.core_api.routes.public.providers import
providers_router
-from airflow.api_fastapi.core_api.routes.public.task_instances import
task_instances_router
-from airflow.api_fastapi.core_api.routes.public.tasks import tasks_router
-from airflow.api_fastapi.core_api.routes.public.variables import
variables_router
-from airflow.api_fastapi.core_api.routes.public.version import version_router
-from airflow.api_fastapi.core_api.routes.public.xcom import xcom_router
+from airflow.api_fastapi.core_api.routes.v2.assets import assets_router
+from airflow.api_fastapi.core_api.routes.v2.backfills import backfills_router
+from airflow.api_fastapi.core_api.routes.v2.config import config_router
+from airflow.api_fastapi.core_api.routes.v2.connections import
connections_router
+from airflow.api_fastapi.core_api.routes.v2.dag_parsing import
dag_parsing_router
+from airflow.api_fastapi.core_api.routes.v2.dag_report import dag_report_router
+from airflow.api_fastapi.core_api.routes.v2.dag_run import dag_run_router
+from airflow.api_fastapi.core_api.routes.v2.dag_sources import
dag_sources_router
+from airflow.api_fastapi.core_api.routes.v2.dag_stats import dag_stats_router
+from airflow.api_fastapi.core_api.routes.v2.dag_tags import dag_tags_router
+from airflow.api_fastapi.core_api.routes.v2.dag_versions import
dag_versions_router
+from airflow.api_fastapi.core_api.routes.v2.dag_warning import
dag_warning_router
+from airflow.api_fastapi.core_api.routes.v2.dags import dags_router
+from airflow.api_fastapi.core_api.routes.v2.event_logs import event_logs_router
+from airflow.api_fastapi.core_api.routes.v2.extra_links import
extra_links_router
+from airflow.api_fastapi.core_api.routes.v2.import_error import
import_error_router
+from airflow.api_fastapi.core_api.routes.v2.job import job_router
+from airflow.api_fastapi.core_api.routes.v2.log import
task_instances_log_router
+from airflow.api_fastapi.core_api.routes.v2.login import login_router
+from airflow.api_fastapi.core_api.routes.v2.monitor import monitor_router
+from airflow.api_fastapi.core_api.routes.v2.plugins import plugins_router
+from airflow.api_fastapi.core_api.routes.v2.pools import pools_router
+from airflow.api_fastapi.core_api.routes.v2.providers import providers_router
+from airflow.api_fastapi.core_api.routes.v2.task_instances import
task_instances_router
+from airflow.api_fastapi.core_api.routes.v2.tasks import tasks_router
+from airflow.api_fastapi.core_api.routes.v2.variables import variables_router
+from airflow.api_fastapi.core_api.routes.v2.version import version_router
+from airflow.api_fastapi.core_api.routes.v2.xcom import xcom_router
-public_router = AirflowRouter(prefix="/public")
+public_router = AirflowRouter(prefix="/v2")
Review Comment:
We could do either, but `/api/v2` is probably what we should do imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
