bugraoz93 commented on issue #47646: URL: https://github.com/apache/airflow/issues/47646#issuecomment-2727450744
https://github.com/apache/airflow/blob/c52ad7e57e4b6df898fc373b78eaa748be1e1f53/airflow/models/connection.py#L374-L394 https://github.com/apache/airflow/blob/c52ad7e57e4b6df898fc373b78eaa748be1e1f53/airflow/models/connection.py#L403 After testing the implementation and inspection, the Provider Connection load part in the `get_hook` needs the `conn_type`. That's why we should keep mandatory if we want to provide test capability for any connections provided and not be limited by what is in the database. After discussions on CLI where we aren't accepting `conn_type` in parameters. I assumed we don't need `conn_type` for API too but, in API people could also test a connection without inserting it into the database to validate before inserting. I think we should keep it because it is more flexible. The only difference is the behaviour with CLI where that is only testing what's in the database. In CLI we are loading from `BaseHook`. Since this is a new endpoint without breaking changes and considering the CLI (remote commands) part will be a completely separate package. We don't need to adopt this behaviour as a bugfix but we should discuss if it should be the same. So closing this for 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
