pierrejeambrun commented on code in PR #47859:
URL: https://github.com/apache/airflow/pull/47859#discussion_r1999346750
##########
providers/fab/src/airflow/providers/fab/www/views.py:
##########
@@ -69,7 +69,9 @@ def index(self):
if g.user is not None and g.user.is_authenticated:
token = get_auth_manager().generate_jwt(g.user)
response = make_response(redirect(f"{conf.get('api',
'base_url')}", code=302))
- response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=True)
+
+ secure = bool(conf.get("api", "ssl_cert"))
+ response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=secure)
Review Comment:
Because apparently the `secure` attribute is not always properly set when
the TLS termination is handled before. (proxy forward header might be a good
place though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
