bugraoz93 commented on code in PR #47869:
URL: https://github.com/apache/airflow/pull/47869#discussion_r1999822483


##########
airflow/api_fastapi/auth/managers/simple/simple_auth_manager.py:
##########
@@ -327,6 +337,21 @@ def _is_authorized(
             return role.order >= allow_get_role.order
         return role.order >= allow_role.order
 
+    @staticmethod
+    def _get_passwords(users: list[dict[str, str]], stream: TextIO) -> 
tuple[dict[str, str], bool]:
+        # Read passwords from file
+        user_passwords_from_file = json.load(stream)

Review Comment:
   Exactly, maybe printing on the used class above in case any JSONDecode error 
is raised similar to the below informing with username and password, we can 
warn that something is wrong with the file. 
   I think it is good to have so it depends on your timing
   ```
   self._print_output(
           f"Password for user '{user['username']}': 
{passwords[user['username']]}"
   )
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to