pierrejeambrun commented on code in PR #47821:
URL: https://github.com/apache/airflow/pull/47821#discussion_r2000560286
##########
airflow/ui/src/pages/Dag/Dag.tsx:
##########
@@ -75,8 +83,9 @@ export const Dag = () => {
<DetailsLayout
dag={dag}
error={error ?? runsError}
- isLoading={isLoading || isLoadingRuns}
+ isLoading={isLoading || isLoadingRuns || isWarningLoading}
Review Comment:
```suggestion
isLoading={isLoading || isLoadingRuns || isLoadingWarning}
```
##########
airflow/ui/src/pages/Dag/Dag.tsx:
##########
@@ -51,6 +55,10 @@ export const Dag = () => {
dagId,
});
+ const { data: warningData, isLoading: isWarningLoading } =
useDagWarningServiceListDagWarnings({
+ dagId,
+ });
+
Review Comment:
Maybe you should pass down the `dagId` to `DetailsLayout` and the warning be
fetched there.
I don't think there is a reason for fetching the warnings there, we will not
display them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
