kaxil commented on code in PR #47918:
URL: https://github.com/apache/airflow/pull/47918#discussion_r2001427176
##########
tests/models/test_taskinstance.py:
##########
@@ -1708,9 +1708,9 @@ def test_xcom_with_multiple_outputs(self, dag_maker):
ti =
dag_maker.create_dagrun(logical_date=timezone.utcnow()).task_instances[0]
ti.task = task
ti.run()
- assert ti.xcom_pull(task_ids=task_id, key=XCOM_RETURN_KEY) == value
- assert ti.xcom_pull(task_ids=task_id, key="key1") == "value1"
- assert ti.xcom_pull(task_ids=task_id, key="key2") == "value2"
+ assert ti.xcom_pull(task_ids=task_id, key=XCOM_RETURN_KEY) ==
json.dumps(value)
+ assert ti.xcom_pull(task_ids=task_id, key="key1") ==
json.dumps("value1")
+ assert ti.xcom_pull(task_ids=task_id, key="key2") ==
json.dumps("value2")
Review Comment:
This is not going to return the following though!
```suggestion
assert ti.xcom_pull(task_ids=task_id, key="key2") == '"value2"'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
