Lee-W commented on code in PR #47381:
URL: https://github.com/apache/airflow/pull/47381#discussion_r2002935934


##########
task_sdk/src/airflow/sdk/definitions/asset/__init__.py:
##########
@@ -451,11 +451,16 @@ def iter_dag_dependencies(self, *, source: str, target: 
str) -> Iterator[DagDepe
 
         :meta private:
         """
+        from airflow.models.asset import retrieve_asset_ids
+        from airflow.utils.session import create_session
+
+        with create_session() as session:
+            asset_id = str(retrieve_asset_ids(assets=[self], 
session=session)[0])
         yield DagDependency(
             source=source or "asset",
             target=target or "asset",
             dependency_type="asset",
-            dependency_id=self.name,
+            dependency_id=asset_id,

Review Comment:
   updated



##########
airflow/models/asset.py:
##########
@@ -96,6 +98,30 @@ def resolve_ref_to_asset(
     return session.scalar(stmt)
 
 
+def resolve_assets_as_dag_dependencies(
+    *,
+    assets: list[Asset],
+    source: str,
+    target: str,
+    session: Session,
+) -> list[DagDependency]:
+    asset_id_names = session.scalars(
+        select(AssetModel.id, AssetAliasModel.name).where(
+            tuple_(AssetModel.name, AssetModel.uri).in_((asset.name, 
asset.uri) for asset in assets)
+        )
+    ).all()
+    return [
+        DagDependency(
+            source=source,
+            target=target,
+            label=asset_name,
+            dependency_type="asset",
+            dependency_id=str(asset_id),
+        )
+        for (asset_id, asset_name) in asset_id_names
+    ]

Review Comment:
   This is removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to