kaxil commented on code in PR #47946: URL: https://github.com/apache/airflow/pull/47946#discussion_r2003035254
########## task-sdk/src/airflow/sdk/definitions/connection.py: ########## @@ -24,7 +24,8 @@ import attrs -from airflow.exceptions import AirflowException +from airflow.exceptions import AirflowException, AirflowNotFoundException +from airflow.sdk.api.datamodels._generated import ConnectionResponse Review Comment: Since this is a user facing class, let's avoid importing `ConnectionResponse` and defining `_convert_connection_to_response` here if at all possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
