vincbeck commented on PR #47691: URL: https://github.com/apache/airflow/pull/47691#issuecomment-2736861027
> One NIT about redirecting all to /dev/null on user creation. ... Even if we need it in case create user does not work and we want to silence it in case of SimpleAuth Manager we probably should do it differently, maybe simply handle user creation silently and print out "No user creation in Simple Auth Manager" and do it in sdout and treat it as success? I agree with the concern, I did not like it either when I was working on it but I could not find a better solution. The problem is we are using `airflow users` in different place and this CI command is provided by FAB auth manager. So when simple auth manager is used, this command fails. > maybe simply handle user creation silently and print out "No user creation in Simple Auth Manager" and do it in sdout and treat it as success? I dont think we should do that because it means that every auth manager then should also have this CLI implemented because this command is used in the CI. Unless we agree that only FAB and simple auth managers are used in the CI and then they should have this command implemented? I am okay with that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
