potiuk commented on PR #47990:
URL: https://github.com/apache/airflow/pull/47990#issuecomment-2739738277

   > Btw 1.1.0 msal-extensions is Dec 2023, should we go newer?
   
   Yes, we could but this is a fine balance between "find the min version that 
works" and  "limiting other libraries that might depend on this one being 
older". 
   
   I think it's fine as it is - beause we know **exactly** when python 3.12 
compatibility was added, and there are two difference between those two 
libraries (1.1.0) - so we can safly assume that when we add this limiation, 
problems with Python 3.12 will be solved.
   
   > [MSAL Extensions for Python, 
1.1.0](https://github.com/AzureAD/microsoft-authentication-extensions-for-python/releases/tag/1.1.0)
   Support Python 3.12 by removing dependency on distutils 
(https://github.com/AzureAD/microsoft-authentication-extensions-for-python/pull/120,
 
https://github.com/AzureAD/microsoft-authentication-extensions-for-python/issues/123)
   Dropping Python 2.7 
(https://github.com/AzureAD/microsoft-authentication-extensions-for-python/pull/122)
   
   * winrm - is  specialized way of connecting to remote windows machine - it's 
used directly by the clients (like our winrm provider) - and it's used for that 
very reason only, so it's ok to bump it higher, because this is unlikely other 
libraries (for example in azure linux incarnations) will depend on earlier 
version of that library and will not be compatible with the newer one
   
   * msal-extensions on the other hand is a library that provides 
authentication extensions -  "It gives additional support to the [Microsoft 
Authentication Library for Python 
(MSAL)](https://github.com/AzureAD/microsoft-authentication-library-for-python)."
  -> so in this case it's likely that someone might want to have a dependency 
and require a bit lower version of the library - there might be potentially 
many other libraries that need it and by bumping it too high, we might 
accidentally limit some of those from being installed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to