ashb commented on a change in pull request #6330: AIRFLOW-5653 Log caught
AirflowSkipException in task instance log
URL: https://github.com/apache/airflow/pull/6330#discussion_r334439416
##########
File path: airflow/models/taskinstance.py
##########
@@ -950,7 +950,10 @@ def signal_handler(signum, frame):
Stats.incr('ti_successes')
self.refresh_from_db(lock_for_update=True)
self.state = State.SUCCESS
- except AirflowSkipException:
+ except AirflowSkipException as e:
+ # log only if exception has any arguments to prevent log flooding
+ if e.args:
+ self.log.warning(e)
Review comment:
Maybe this should be at info level? It doesn't really seem like a "warning"
to me.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
