eladkal commented on code in PR #48008: URL: https://github.com/apache/airflow/pull/48008#discussion_r2006125877
########## providers/amazon/src/airflow/providers/amazon/aws/notifications/sns.py: ########## @@ -20,8 +20,8 @@ from collections.abc import Sequence from functools import cached_property -from airflow.notifications.basenotifier import BaseNotifier from airflow.providers.amazon.aws.hooks.sns import SnsHook +from airflow.providers.common.compat.nofitier import BaseNotifier Review Comment: > Maybe we should instead force all users to always upgrade to the latest common? It defeats the entire purpose of having a compat package if we need to do try-except. If a try-except is necessary, we may as well just do that against the actual modules. I guess we can and have a todo to remove the dependency when min version of providers is Airflow 3 (assuming Airflow 3 set version as part as the pre installed providers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
