o-nikolas commented on code in PR #47968:
URL: https://github.com/apache/airflow/pull/47968#discussion_r2006143066
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -102,7 +103,7 @@ def __init__(
table: str | None = None,
select_query: str | None = None,
redshift_conn_id: str = "redshift_default",
- aws_conn_id: str | None = "aws_default",
+ aws_conn_id: str | None | ArgNotSet = NOTSET,
Review Comment:
I see your concern now, that's fair. The check on line 189 (in the new diff)
no longer checks for None like it did previously, good catch! I can update the
code to set `conn_not_set` to False if the input is either None or an instance
of ArgNotSet. That should retain the old behaviour of short circuiting that
ternary operator like it did before when input was None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
