jedcunningham commented on code in PR #48032:
URL: https://github.com/apache/airflow/pull/48032#discussion_r2008457661
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -95,7 +95,9 @@ def __init__(
):
super().__init__(job)
if capacity is None:
- self.capacity = conf.getint("triggerer", "default_capacity",
fallback=1000)
+ # PR 48032 renames the triggerer default_capacity to capacity. The
precedence is capacity ->
+ # default_capacity -> 1000
Review Comment:
```suggestion
```
We don't need to keep this comment around.
##########
chart/values.yaml:
##########
@@ -2710,8 +2713,8 @@ config:
worker_container_repository: '{{ .Values.images.airflow.repository |
default .Values.defaultAirflowRepository }}'
worker_container_tag: '{{ .Values.images.airflow.tag | default
.Values.defaultAirflowTag }}'
multi_namespace_mode: '{{ ternary "True" "False"
.Values.multiNamespaceMode }}'
- triggerer:
- default_capacity: 1000
+
+
Review Comment:
```suggestion
```
##########
chart/values.yaml:
##########
@@ -1805,8 +1805,11 @@ triggerer:
# periodSeconds: 15
# Query to use for KEDA autoscaling. Must return a single integer.
+ # PR 48032 renames default_capacity to capacity for Airflow 3.0. However,
this chart will be used for
+ # both Airflow 2.X and 3.0. Here, we're updating the query to point to
either 1) capacity,
+ # 2) default_capacity, or 3) 1000.
Review Comment:
We don't need this comment.
##########
chart/templates/_helpers.yaml:
##########
@@ -664,6 +664,12 @@ server_tls_key_file = /etc/pgbouncer/server.key
{{- include "_serviceAccountName" (merge (dict "key" "triggerer") .) -}}
{{- end }}
+{{/* PR 48032 renames triggerer.default_capacity to capacity, and falls back
to a default value */}}
Review Comment:
```suggestion
{{/* Determine trigger capacity, taking Airflow 2 and 3 config option
differences into account*/}}
```
Generally, we try not to place pr numbers around - we can always get at that
by doing a blame - so it's better to just explain what this does instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
