sunank200 commented on code in PR #48002:
URL: https://github.com/apache/airflow/pull/48002#discussion_r2009998400
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -566,7 +566,9 @@ def _prepare(ti: RuntimeTaskInstance, log: Logger, context:
Context) -> ToSuperv
def run(
- ti: RuntimeTaskInstance, log: Logger
+ ti: RuntimeTaskInstance,
+ context: Context,
+ log: Logger,
) -> tuple[IntermediateTIState | TerminalTIState, ToSupervisor | None,
BaseException | None]:
"""Run the task in this process."""
Review Comment:
nit: arguments in doc-strings are missing.
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -792,6 +793,25 @@ def _handle_trigger_dag_run(
return _handle_current_task_success(context, ti)
+def _run_task_state_change_callbacks(
+ task: BaseOperator,
+ kind: Literal[
+ "on_execute_callback",
+ "on_failure_callback",
+ "on_success_callback",
+ "on_retry_callback",
+ "on_skipped_callback",
+ ],
+ context: Context,
+ log: Logger,
+) -> None:
Review Comment:
nit: we can add doc-strings.
##########
task-sdk/tests/conftest.py:
##########
@@ -204,6 +204,7 @@ def _make_context(
run_type: str = "manual",
task_reschedule_count: int = 0,
conf=None,
+ should_retry=False,
Review Comment:
Also typing for conf is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
