jieyao-MilestoneHub commented on code in PR #48120:
URL: https://github.com/apache/airflow/pull/48120#discussion_r2012126582
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/exasol_to_s3.py:
##########
@@ -108,5 +108,4 @@ def execute(self, context: Context):
gzip=self.gzip,
acl_policy=self.acl_policy,
)
- self.log.info("Data uploaded")
- return self.key
Review Comment:
Previously, @vincbeck suggested removing the return value, and since I
noticed some files had it while others didn’t, I removed it without being fully
certain of the reason.
If it's confirmed that the value is used via XCom, I’ll definitely keep it.
That said, I’m curious—are there cases where it's used in XCom but the operator
doesn't return anything? For example, salesforce_to_s3.py and glacier_to_gcs.py
return values, while ftp_to_s3.py and dynamodb_to_s3.py don’t. I’d appreciate
any guidance or examples you might have!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
