jedcunningham commented on code in PR #48070:
URL: https://github.com/apache/airflow/pull/48070#discussion_r2012800509
##########
airflow-core/src/airflow/dag_processing/collection.py:
##########
@@ -197,6 +197,7 @@ def _serialize_dag_capturing_errors(
session=session,
)
if dag_was_updated:
+ if "FabAuthManager" in conf.get("core", "auth_manager"):
_sync_dag_perms(dag, session=session)
Review Comment:
_sync_dag_perms was meant to be in another level under that new if...
but, that does make me wonder if we need to abstract this into the auth
manager interface. It's a bit of a code smell that we have a FAB specific
callout here imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
