pierrejeambrun commented on code in PR #48239:
URL: https://github.com/apache/airflow/pull/48239#discussion_r2014657655
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -311,8 +352,25 @@ def _handle_request(self, msg: ToTriggerSupervisor, log:
FilteringBoundLogger) -
if factory := self.logger_cache.pop(id, None):
factory.upload_to_remote()
return
Review Comment:
It does prettty much nothing, it's a return only that will save a boolean
check down the line `if resp:` (resp is always None in this case).
Not needed and maybe confusing, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
