jscheffl commented on code in PR #48109:
URL: https://github.com/apache/airflow/pull/48109#discussion_r2014984735
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.py:
##########
@@ -569,7 +608,7 @@ def test_patch_should_respond_404(self, test_client, body):
@pytest.mark.enable_redact
@pytest.mark.parametrize(
- "body, expected_response",
+ "body, expected_response, update_mask",
Review Comment:
Oh, we should. Especially because of the Alias and logic you requested to
make "better" the current pytest found a regression. Actually needed to scratch
my head 3-times until I found the bug.
The more I look on the revised code comparing to the previous list the more
I hate it. Over generlized. And error prone because of aliases. So we SHOULD
keep this pytest with update mask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
