kaxil commented on code in PR #48446:
URL: https://github.com/apache/airflow/pull/48446#discussion_r2016919315
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1070,14 +1068,12 @@ def forward_to_log(
log.log(level, msg, chan=chan)
-def initialize_secrets_backend_on_workers():
+def ensure_secrets_backend_loaded() -> list[BaseSecretsBackend]:
"""Initialize the secrets backend on workers."""
from airflow.configuration import ensure_secrets_loaded
from airflow.secrets import DEFAULT_SECRETS_SEARCH_PATH_WORKERS
- global SECRETS_BACKEND
- SECRETS_BACKEND =
ensure_secrets_loaded(default_backends=DEFAULT_SECRETS_SEARCH_PATH_WORKERS)
- log.debug("Initialized secrets backend on workers",
secrets_backend=SECRETS_BACKEND)
+ return
ensure_secrets_loaded(default_backends=DEFAULT_SECRETS_SEARCH_PATH_WORKERS)
Review Comment:
Yeah it does. Just checks the length or compares the list of backends.
It could be better but that's for other time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
