Re: [PR] Add support to get XComs with 'include_prior


amoghrajesh commented on code in PR #48440:
URL: https://github.com/apache/airflow/pull/48440#discussion_r2017122380



##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py:
##########
@@ -131,12 +131,22 @@ def get_xcom(
     run_id: str,
     task_id: str,
     key: str,
-    xcom_query: Annotated[Select, Depends(xcom_query)],
+    session: SessionDep,
     map_index: Annotated[int, Query()] = -1,
+    include_prior_dates: Annotated[bool, Query()] = False,

Review Comment:
   Yep just made changes and tested it
   ## API versioning
   
   - Added API versioning too, it is not essentially needed but good to have to 
get used to it. Followed 
https://fastapi.tiangolo.com/tutorial/query-param-models/#query-parameters-with-a-pydantic-model
   
   
![image](https://github.com/user-attachments/assets/cf0d6d54-d5d7-4eb2-8492-d7655af874c4)
   
   Get XCom in 26/03 version (newest)
   
![image](https://github.com/user-attachments/assets/5e78b28c-9283-4e92-a9e1-bafe5a72a254)
   
   Get Xcom in 19/03 version
   
![image](https://github.com/user-attachments/assets/c264acf4-d03d-4c5f-b808-ca696a32e8a0)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] Add support to get XComs with 'include_prior_dates' [airflow]

Reply via email to