ashb commented on code in PR #48491: URL: https://github.com/apache/airflow/pull/48491#discussion_r2021795451
########## airflow-core/src/airflow/logging/remote.py: ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import os +from typing import TYPE_CHECKING, Protocol + +import attrs + +if TYPE_CHECKING: + import structlog.typing + + from airflow.utils.log.file_task_handler import LogMessages, LogSourceInfo + + [email protected] +class RemoteLogIO(Protocol): + """Interface for remote task loggers.""" + + @property + def processors(self) -> tuple[structlog.typing.Processor, ...]: ... + + """ + List of structlog processors to install in the task write path. + + This is useful if a remote logging provider wants to either transform the structured log messages as they + are being written to a file, or if you want to upload messages as they are generated. + """ + + def upload(self, path: os.PathLike | str): + """Upload the given log path to the remote storage.""" + + def read(self, relative_path: str) -> tuple[LogSourceInfo, LogMessages | None]: + """Read logs from the given remote log path.""" + raise NotImplementedError() Review Comment: No we don't. I had made this a base class, but we can't use that in providers, so I changed it to a protocol but left this behind. Will fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
