eladkal commented on code in PR #45931:
URL: https://github.com/apache/airflow/pull/45931#discussion_r2023517222


##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -1265,6 +1265,20 @@ secrets:
       sensitive: true
       example: ~
       default: ""
+    backends_order:
+      description: |
+        Comma-separated list of secret backends. These backends will be used 
in the order they are specified.
+        Please note that the `environment_variable` and `metastore` are 
required values and cannot be removed
+        from the list. Supported values are:
+
+        * ``custom``: Custom secret backend specified in the 
``secrets[backend]`` configuration option.
+        * ``environment_variable``: Standard environment variable backend
+          
``airflow.secrets.environment_variables.EnvironmentVariablesBackend``.
+        * ``metastore``: Standard metastore backend 
``airflow.secrets.metastore.MetastoreBackend``.
+      version_added: 3.0.0
+      type: string
+      example: ~
+      default: "custom,environment_variable,metastore"

Review Comment:
   right now it's not configurable so the Airflow docs is good enough but after 
this PR is accepted the Airflow docs can't help you... You'll need to check the 
deployment to understand the priority order.
   In many deployments dag authors don't have access to the deployment code.
   
   My thoughts on the UI is an improvement (I think crucial but that is just my 
own perspective) I welcome others to share their thoughts. This feature is 
already targeting 3.1+ so regardless if we do the UI part or not we can't merge 
it now. We need to wait for main branch to become 3.1 (probably only after we 
cut RC1 for Airflow 3(



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to