BasPH commented on a change in pull request #6252: [AIRFLOW-4676] Make
airflow/macros Pylint compatible
URL: https://github.com/apache/airflow/pull/6252#discussion_r335300173
##########
File path: airflow/macros/__init__.py
##########
@@ -91,4 +92,4 @@ def _integrate_plugins():
from airflow.plugins_manager import macros_modules
for macros_module in macros_modules:
sys.modules[macros_module.__name__] = macros_module
- globals()[macros_module._name] = macros_module
+ globals()[macros_module.__name__.split('.')[-1]] = macros_module
Review comment:
I don't see any problem naming it `name`, the name won't be edited and is
fine to "expose".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services