Re: [PR] Fix discord and slack provider icon url [airflow]

[via GitHub]

eladkal commented on code in PR #48680:
URL: https://github.com/apache/airflow/pull/48680#discussion_r2024959809


##########
providers/discord/src/airflow/providers/discord/notifications/discord.py:
##########
@@ -22,7 +22,7 @@
 from airflow.providers.common.compat.notifier import BaseNotifier
 from airflow.providers.discord.hooks.discord_webhook import DiscordWebhookHook
 
-ICON_URL: str = 
"https://raw.githubusercontent.com/apache/airflow/main/airflow/www/static/pin_100.png";
+ICON_URL: str = 
"https://raw.githubusercontent.com/apache/airflow/2.5.0/airflow/www/static/pin_100.png";

Review Comment:
   It should be
   
`https://raw.githubusercontent.com/apache/airflow/main/airflow-core/src/airflow/ui/public/pin_32.png`
   though I am not sure about the size impact
   
   @bbovenzi do you know why we removed the pin_100.png from source code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org