gopidesupavan commented on PR #48747:
URL: https://github.com/apache/airflow/pull/48747#issuecomment-2775974931

   @kaxil for now i have added to Fix only `DagStateTrigger`. i have observed 
few issues with ExternalTaskSensor with WorkflowTrigger. while testing, date 
calcutlation needs to be changed here, 
https://github.com/apache/airflow/pull/48651/files#diff-cd0a81a3fe4e14f46d41d402eabcb273554245c7e676e549b8b84030a99d4870R255
 . the logical_date is current dag, when we monitoring external task/dag that 
contians different logical date, so causing this queries failures. 
   
   Additionally here logical_date argument is not available in WorkflowTrigger, 
overall it needs some good amount of tetsing i feel will do it separate, may 
not be possible for RC
   
   
https://github.com/apache/airflow/blob/00a3df160d0cf6b8c2a90b30f32551d22547ff56/providers/standard/src/airflow/providers/standard/sensors/external_task.py#L430
 
   
   Atleast i would like to `DagStateTrigger` to be ready for review and merge 
for RC. so raised it here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to