vincbeck commented on PR #48754: URL: https://github.com/apache/airflow/pull/48754#issuecomment-2776938043
> Is it a good idea to change the signature too to `User | None` for correctness so that mypy can catch other places where None needs to be handled but I guess it will have more effort in changing all functions that use it. > > https://github.com/apache/airflow/blob/14788f6c81ab94bbec902c3c1377a57245a64f3d/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py#L268 This is a very edge case of FAB auth manager. I am not willing to update the auth manager interface and therefore all auth managers for this very specific edge case very specific to FAB auth manager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
