sean-rose opened a new pull request, #48780: URL: https://github.com/apache/airflow/pull/48780
Since `TaskInstanceHistory` records are now used as the basis for showing previous task tries in the "Details", "Gantt", and "Logs" tabs (#40304), it's important they are recorded reliably. After upgrading our Airflow instance from 2.9.3 to 2.10.5 we discovered that links to previous task tries which failed and were retried per their `retries` setting aren't showing up in the Airflow UI (similar to #43739), and I've confirmed this is due to the associated `TaskInstanceHistory` records not being successfully persisted to the database despite the [`TaskInstanceHistory.record_ti()` call for retries](https://github.com/apache/airflow/blob/12a124af3d0483ae85c01874bcb45effa6834e26/airflow/models/taskinstance.py#L3377) happening (in our case I suspect it's due to unintended side effects of the `on_retry_callback` that [`acryl-datahub-airflow-plugin` 0.13.2.4](https://pypi.org/project/acryl-datahub-airflow-plugin/0.13.2.4/) is [adding to all our tasks](https://github.com/datahub-project/datahub/blob/0a8ec376b7c6963772a167e08837dce8b480af7c/metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/datahub_plugin_v22.py#L337), as disabling that plugin makes the prob lem go away). This change is meant to ensure that `TaskInstanceHistory` records are always persisted, despite things potentially going awry later in the retry handling. related: #43739 <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
