prabhusneha commented on code in PR #48648:
URL: https://github.com/apache/airflow/pull/48648#discussion_r2028399489
##########
airflow-core/src/airflow/serialization/helpers.py:
##########
@@ -71,7 +66,7 @@ def translate_tuples_to_lists(obj: Any):
)
return serialized
else:
- if not template_field:
+ if not template_field and not isinstance(template_field, tuple):
Review Comment:
Yes this is added for empty tuple case.
To call `translate_tuples_to_lists` somewhere near where you mentioned, we'd
still have do additional serialization steps and check on max_length, as
mentioned here
https://github.com/apache/airflow/blob/ba0d3cd77331d27f39d7e69748c8a0865daf9b87/airflow-core/src/airflow/serialization/helpers.py#L77-L83
This feels like a lot of code duplication to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
