bbovenzi commented on code in PR #47900:
URL: https://github.com/apache/airflow/pull/47900#discussion_r2012217241
##########
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##########
@@ -98,7 +115,33 @@ export const PanelButtons = ({ dagView, setDagView, ...rest
}: Props) => {
</IconButton>
</ButtonGroup>
<Stack alignItems="flex-end" gap={1} mr={2}>
- <DagVersionSelect disabled={dagView !== "graph"} />
+ <HStack>
+ <DagVersionSelect disabled={dagView !== "graph"} />
+ {dagView === "grid" ? (
+ <Select.Root
+ bg="bg"
+ collection={displayRunOptions}
+ data-testid="display-dag-run-options"
+ onValueChange={handleLimitChange}
+ size="sm"
+ width="200px"
+ >
+ <Select.Trigger>
+ <Select.ValueText placeholder="Display Dag Run Limit" />
Review Comment:
It would probably be better for us to have 10 selected by default instead of
a placeholder or the clear button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
