jedcunningham commented on code in PR #48032:
URL: https://github.com/apache/airflow/pull/48032#discussion_r2006809701
##########
airflow/jobs/triggerer_job_runner.py:
##########
@@ -95,7 +95,7 @@ def __init__(
):
super().__init__(job)
if capacity is None:
- self.capacity = conf.getint("triggerer", "default_capacity",
fallback=1000)
+ self.capacity = conf.getint("triggerer", "capacity", fallback=1000)
Review Comment:
```suggestion
self.capacity = conf.getint("triggerer", "capacity")
```
While we are here, let's remove the unnecessary fallback.
##########
chart/values.yaml:
##########
@@ -2711,7 +2711,7 @@ config:
worker_container_tag: '{{ .Values.images.airflow.tag | default
.Values.defaultAirflowTag }}'
multi_namespace_mode: '{{ ternary "True" "False"
.Values.multiNamespaceMode }}'
triggerer:
- default_capacity: 1000
+ capacity: 1000
Review Comment:
This isn't a straightforward change in the chart though, as the chart
supports both Airflow 2 and 3.
It might make sense to just set both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
