hussein-awala commented on code in PR #47968:
URL: https://github.com/apache/airflow/pull/47968#discussion_r2004471442
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -102,7 +103,7 @@ def __init__(
table: str | None = None,
select_query: str | None = None,
redshift_conn_id: str = "redshift_default",
- aws_conn_id: str | None = "aws_default",
+ aws_conn_id: str | None | ArgNotSet = NOTSET,
Review Comment:
I understand your arguments, but when the user provides a `None` value,
`conn_not_set` will be `False` and `_aws_conn_id` will be `None`, then `conn =
S3Hook.get_connection(conn_id=self._aws_conn_id) if not self.conn_not_set else
None` will be evaluated as `conn = S3Hook.get_connection(conn_id=None)` which
is not the case today, and I don't know if in this case, the operator will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
