kaxil commented on code in PR #48651:
URL: https://github.com/apache/airflow/pull/48651#discussion_r2025838150
##########
task-sdk/tests/task_sdk/api/test_client.py:
##########
@@ -904,6 +946,58 @@ def handle_request(request: httpx.Request) ->
httpx.Response:
assert result == DagRunStateResponse(state=DagRunState.RUNNING)
+ def test_get_count_basic(self):
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ return httpx.Response(status_code=200, json=1)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(dag_id="test_dag")
+ assert result == 1
Review Comment:
```suggestion
assert result.count == 1
```
##########
task-sdk/tests/task_sdk/api/test_client.py:
##########
@@ -904,6 +946,58 @@ def handle_request(request: httpx.Request) ->
httpx.Response:
assert result == DagRunStateResponse(state=DagRunState.RUNNING)
+ def test_get_count_basic(self):
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ return httpx.Response(status_code=200, json=1)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(dag_id="test_dag")
+ assert result == 1
+
+ def test_get_count_with_states(self):
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ assert request.url.params.get_list("states") == ["success",
"failed"]
+ return httpx.Response(status_code=200, json=2)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(dag_id="test_dag",
states=["success", "failed"])
+ assert result == 2
+
+ def test_get_count_with_logical_dates(self):
+ logical_dates = [timezone.datetime(2025, 1, 1),
timezone.datetime(2025, 1, 2)]
+ logical_dates_str = [d.isoformat() for d in logical_dates]
+
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ assert request.url.params.get_list("logical_dates") ==
logical_dates_str
+ return httpx.Response(status_code=200, json=2)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(
+ dag_id="test_dag", logical_dates=[timezone.datetime(2025, 1, 1),
timezone.datetime(2025, 1, 2)]
+ )
+ assert result == 2
+
+ def test_get_count_with_run_ids(self):
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ assert request.url.params.get_list("run_ids") == ["run1",
"run2"]
+ return httpx.Response(status_code=200, json=2)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(dag_id="test_dag", run_ids=["run1",
"run2"])
+ assert result == 2
Review Comment:
```suggestion
assert result.count == 2
```
##########
task-sdk/tests/task_sdk/api/test_client.py:
##########
@@ -904,6 +946,58 @@ def handle_request(request: httpx.Request) ->
httpx.Response:
assert result == DagRunStateResponse(state=DagRunState.RUNNING)
+ def test_get_count_basic(self):
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ return httpx.Response(status_code=200, json=1)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(dag_id="test_dag")
+ assert result == 1
+
+ def test_get_count_with_states(self):
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ assert request.url.params.get_list("states") == ["success",
"failed"]
+ return httpx.Response(status_code=200, json=2)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(dag_id="test_dag",
states=["success", "failed"])
+ assert result == 2
Review Comment:
```suggestion
assert result.count == 2
```
##########
task-sdk/tests/task_sdk/api/test_client.py:
##########
@@ -904,6 +946,58 @@ def handle_request(request: httpx.Request) ->
httpx.Response:
assert result == DagRunStateResponse(state=DagRunState.RUNNING)
+ def test_get_count_basic(self):
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ return httpx.Response(status_code=200, json=1)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(dag_id="test_dag")
+ assert result == 1
+
+ def test_get_count_with_states(self):
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ assert request.url.params.get_list("states") == ["success",
"failed"]
+ return httpx.Response(status_code=200, json=2)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(dag_id="test_dag",
states=["success", "failed"])
+ assert result == 2
+
+ def test_get_count_with_logical_dates(self):
+ logical_dates = [timezone.datetime(2025, 1, 1),
timezone.datetime(2025, 1, 2)]
+ logical_dates_str = [d.isoformat() for d in logical_dates]
+
+ def handle_request(request: httpx.Request) -> httpx.Response:
+ if request.url.path == "/dag-runs/count":
+ assert request.url.params["dag_id"] == "test_dag"
+ assert request.url.params.get_list("logical_dates") ==
logical_dates_str
+ return httpx.Response(status_code=200, json=2)
+ return httpx.Response(status_code=422)
+
+ client = make_client(transport=httpx.MockTransport(handle_request))
+ result = client.dag_runs.get_count(
+ dag_id="test_dag", logical_dates=[timezone.datetime(2025, 1, 1),
timezone.datetime(2025, 1, 2)]
+ )
+ assert result == 2
Review Comment:
```suggestion
assert result.count == 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
