pierrejeambrun commented on code in PR #48584:
URL: https://github.com/apache/airflow/pull/48584#discussion_r2030852843
##########
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx:
##########
@@ -105,15 +112,19 @@ const ClearTaskInstanceDialog = ({ onClose, open,
taskInstance }: Props) => {
multiple
onChange={setSelectedOptions}
options={[
- { disabled: taskInstance.logical_date === null, label: "Past",
value: "past" },
- { disabled: taskInstance.logical_date === null, label:
"Future", value: "future" },
+ { disabled: !Boolean(logicalDate), label: "Past", value:
"past" },
+ { disabled: !Boolean(logicalDate), label: "Future", value:
"future" },
{ label: "Upstream", value: "upstream" },
{ label: "Downstream", value: "downstream" },
{ label: "Only Failed", value: "onlyFailed" },
]}
/>
</Flex>
- <ActionAccordion affectedTasks={affectedTasks} note={note}
setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}
Review Comment:
Added to my todo list, I'll work on the backend part soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
