pierrejeambrun commented on code in PR #48835:
URL: https://github.com/apache/airflow/pull/48835#discussion_r2031087406
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -463,6 +468,9 @@ def emit_metrics(self):
)
def _send(self, msg: BaseModel):
+ self.trigger_stdin.write(msg.model_dump_json().encode("utf-8") +
b"\n") # type: ignore[union-attr]
Review Comment:
That type ignore seems of. It wasn't necessary before and it seems really
similar now:
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -540,6 +540,13 @@ class CommsDecoder(Generic[ReceiveMsgType, SendMsgType]):
input: TextIO
+ """"
+ It require special case to handle the workloads and api calls to
api-server, due to mixing up messages
+ a separate channel is used to send the workloads from parent process to
child process the child process.
+ connect_stdin will use this channel to read the workloads in read_workload
method.
+ """
Review Comment:
If I remember correctly those should field docstring should go bellow the
attr they describe, not above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
