jbdyn opened a new pull request, #48871:
URL: https://github.com/apache/airflow/pull/48871
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
[In a PR](https://github.com/nvim-treesitter/nvim-treesitter/pull/7788)
about how to syntax-highlight Python docstrings, @rmuir and I discovered that
instead of implicit concatenation of strings a string plus a docstring have
been written.
Since this is a subtle one, I want to briefly show the differences:
The false friend of implicit string concatenation
```python
# var == "foo"
var = "foo" # <-- no implicit string concatenation
"bar" # <-- docstring, legal for the bytecode compiler, against PEP
257
```
can be fixed for example with surrounding brackets:
```python
# var == "foobar"
var = (
"foo" # <-- gets implicitly concatenated
"bar"
)
```
I felt free to fix the ones I found right away such that the tests pass.
I searched with [`ripgrep`](https://github.com/BurntSushi/ripgrep) in the
project's root like so:
```sh
# in path/to/cloned/pandas
rg -A 1 -B 2 -U ' = f?"[^"]*"\s+f?"[^"]+"\s*' -t py .
```
I am pretty confident to have catched all cases with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
