ashb commented on code in PR #48791:
URL: https://github.com/apache/airflow/pull/48791#discussion_r2033186881
##########
task-sdk/src/airflow/sdk/execution_time/secrets_masker.py:
##########
@@ -65,7 +65,16 @@
)
"""Names of fields (Connection extra, Variable key name etc.) that are deemed
sensitive"""
-SECRETS_TO_SKIP_MASKING_FOR_TESTS = {"airflow"}
+SECRETS_TO_SKIP_MASKING = {"airflow"}
+"""Common terms that should be excluded from masking in both production and
tests"""
+
+
+@cache
+def get_min_secret_length() -> int:
+ """Get minimum length for a secret to be considered for masking from
airflow.cfg."""
+ from airflow.configuration import conf
+
+ return conf.getint("core", "min_secret_length", fallback=5)
Review Comment:
```suggestion
return conf.getint("logging", "min_length_masked_secret", fallback=5)
```
please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]