ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335964325
########## File path: airflow/lineage/backend/__init__.py ########## @@ -16,13 +16,12 @@ # specific language governing permissions and limitations # under the License. # -"""Sends lineage metadata to a backend""" +"""Send lineage metadata to a backend""" class LineageBackend: - """Sends lineage metadata to a backend""" - def send_lineage(self, - operator=None, inlets=None, outlets=None, context=None): + """Sends lineage metadata to a backend.""" + def send_lineage(self, operator, inlets, outlets, context): Review comment: I imagine Pylint was complaining because the subclass had a different signature? If so the change should be to the subclass to make them optional, not removing the optional here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
